feat(evmrpc): align transaction errors with geth - #4102
Draft
alexander-sei wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4102 +/- ##
==========================================
- Coverage 61.21% 60.28% -0.94%
==========================================
Files 2196 2088 -108
Lines 193395 180580 -12815
==========================================
- Hits 118386 108854 -9532
+ Misses 63793 61584 -2209
+ Partials 11216 10142 -1074
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Implements RFC 009 for
eth_sendRawTransaction.Unknown internal submission failures now return
-32603 internal error; known geth-compatible submission failures retain-32000, and request timeouts use-32002.Testing performed to validate your change
scripts/ramtest.sh ./evmrpc/... ./app/ante -run ... -count=1go test ./sei-tendermint/internal/proxy -run TestCheckTxSafe -count=1go test ./integration_test/evm_module/rpc_io_test -run TestParseIOFile_TestdataDir -count=1npx tsc --noEmitinintegration_test/rpc_testsnode --check contracts/test/lib.jsnode --check contracts/test/EVMCompatabilityTest.jsmake fmtcheckgolangci-lintover the changed Go packagesgit diff --checkThe live Docker RPC integration suite was not run locally; keeping this PR in draft until that environment-backed gate runs.